Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move tags init to prevent tag keys persisting. #18

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Move tags init to prevent tag keys persisting. #18

merged 1 commit into from
Mar 27, 2023

Conversation

heathstannard
Copy link
Contributor

In a case where tags are missing from items, they are currently populated by the previous items values. eg:

<?xml version="1.0" encoding="UTF-8"?>
<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9" xmlns:xhtml="http://www.w3.org/1999/xhtml">
<url><loc>https://testing.ddev.site/lorem</loc><changefreq>monthly</changefreq><priority>0.8</priority></url>
<url><loc>https://testing.ddev.site/ipsum</loc><changefreq>monthly</changefreq><priority>0.8</priority></url>
<url><loc>https://testing.ddev.site/dolor</loc><changefreq>monthly</changefreq><priority>0.2</priority></url>
<url><changefreq>monthly</changefreq><priority>0.8</priority></url>
<url><loc>https://testing.ddev.site/sit</loc></url>
</urlset>

This change ensures tags are reset for each item.

@heathstannard
Copy link
Contributor Author

Hi @JanPetterMG - would we be able to get this into a new release after review? thank you!

@jastraat
Copy link

@vpominchuk any chance you could review this and make a new release?

@vpominchuk
Copy link
Contributor

@vpominchuk any chance you could review this and make a new release?

I'm sorry, but I'm not a maintainer of the project.

@heathstannard
Copy link
Contributor Author

@JanPetterMG Sorry to nudge you again but this package is used as a dependency on a widely used Drupal module and this bug is preventing that module from being updated and in turn - many projects from being able to upgrade to Drupal 10. Is there any chance we could get this reviewed or at least pointed toward someone who could? Thanks

@JanPetterMG JanPetterMG merged commit c263e1f into VIPnytt:master Mar 27, 2023
@JanPetterMG
Copy link
Collaborator

Sorry I'm late to the party, version 1.1.7 is now out.

@heathstannard heathstannard deleted the namespace-bugfix branch March 27, 2023 17:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants