Change client creation to allow override #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 23, 2023 14:37
The SitemapParser constructor now accepts a GuzzleHttp client as a parameter, improving flexibility and testability
…for automatic retries on failed requests, and for throttling requests to prevent rate limit issues. Detailed instructions for implementation of these middlewares have been added to the README file.
The commit includes the addition of the "gmponos/guzzle-log-middleware" library in the composer.json file and the detailed instructions to use it in the README.md. This addition would enhance the application's logging and debugging abilities.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SitemapParser constructor now accepts a GuzzleHttp client as a parameter, improving flexibility and testability
The README and composer.json have been updated to suggest middleware for automatic retries on failed requests, and for throttling requests to prevent rate limit issues. Detailed instructions for implementation of these middlewares have been added to the README file.