-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(Flex): refactor gaps #7492
fix(Flex): refactor gaps #7492
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 3924fd6 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7492 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 384 384
Lines 11212 11221 +9
Branches 3674 3679 +5
=======================================
+ Hits 10671 10680 +9
Misses 541 541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Косяк с целевой веткой?) |
b634353
to
cb6ab9f
Compare
Т.к. CSS св-во `gap` применяется только при наличии нескольких потомков, добавляем в наш фолбек такую же логику основываясь на передачу пропа `gap` и количество элементов в пропе `children`.
cb6ab9f
to
3924fd6
Compare
поправил, спасибо ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Код
<Button></Button>
<Button></Button>
<Flex gap="xs">
{new Array(3).fill(3).map((i) => (
<div style={{ width: '36px', height: '36px', borderRadius: '50%', border: '1px solid red' }} key={i}>
<Flex
align="center"
justify="center"
style={{ width: '36px', height: '36px', border: '1px solid blue' }}
>
VKUI
</Flex>
</div>
))}
</Flex> |
Описание
Т.к. CSS св-во
gap
применяется только при наличии нескольких потомков,добавляем в наш фолбек такую же логику основываясь:
gap
;children
;