Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow empty skills #482

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Allow empty skills #482

merged 5 commits into from
Apr 12, 2021

Conversation

jcoupey
Copy link
Collaborator

@jcoupey jcoupey commented Apr 9, 2021 •
edited
Loading

Issue

This PR fixes #460 by removing the current checks that ensure that skills are either always or never provided. The resulting behavior should still be consistent with the current definition of how skills work.

Tasks

  • Allow mixing empty and non-empty skills arrays in input
  • Update docs/API.md
  • Update CHANGELOG.md
  • review

@jcoupey jcoupey added this to the v1.10.0 milestone Apr 9, 2021
@jcoupey jcoupey merged commit 1e32124 into master Apr 12, 2021
@jcoupey jcoupey deleted the enhancement/allow-empty-skills branch April 12, 2021 10:08
@jcoupey jcoupey mentioned this pull request Oct 4, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API enhancement
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

Skills definition
1 participant
@jcoupey