Fixes gj/gk behaviour on wrapped lines; closes #4120 #4127
Conversation
This more or less reverts the functionality introduced by commit 4b2e079 and raised in issue VSCodeVim#3890. Unfortunately it is not currently possible to fully implement display line movements over wrapped lines that will always preserve cursor position. One of two things is necessary to change this, either the VSCode API needs to be extended to return information about wrapped lines (but this was rejected in issue microsoft/vscode#23045). Alternatively VSCodeVim would need to reïimplement all motions using vscode.commands.executeCommand() commands rather than manipulating vscode.window.activeTextEditor.selections directly, as the former preserves column position while the latter does not. However it's not clear to me if all VIM beahviour could be reïmplemented this way without first trying this out and sounds like a bit of a ground up rewrite. It seems for now we're stuck with gj/gk not preserving column position when jumping across short lines.
Why's this? Aren't basically all motions other than |
@J-Fields, this is specific to maintaining the column position. What I gathered from microsoft/vscode#23045 is that VSCode already maintains column position for us. This works OK as long as we manipulate the cursor via Unfortunately, the only code with an awareness of the display column position when wrapping is turned on, is the internals of VSCode and it seems the developers are uninterested in exposing this. So the only option would be to implement all motions using Without trying this I'm not sure if there would be any corner cases where VIM behaviour could not be expressed using existing VSCode commands, however the developers did indicate that they would be open to adding additional commands as needed on a case by case basis. |
These tests had been previously removed as supporting this behaviour is not yet possible due to technical reasons, however they do represent correct VIM behaviour so we keep them until implementation becomes architecturally possible.
|
Got it, thanks! Shame there isn't an API for this. |
Closes #4120. This more or less reverts the functionality introduced by commit
4b2e079 and raised in issue #3890.
Unfortunately it is not currently possible to fully implement display
line movements over wrapped lines that will always preserve cursor
position. One of two things is necessary to change this, either the
VSCode API needs to be extended to return information about wrapped
lines (but this was rejected in issue microsoft/vscode#23045).
Alternatively VSCodeVim would need to reïimplement all motions using
vscode.commands.executeCommand() commands rather than manipulating
vscode.window.activeTextEditor.selections directly, as the former
preserves column position while the latter does not. However it's not
clear to me if all VIM beahviour could be reïmplemented this way without
first trying this out and sounds like a bit of a ground up rewrite.
It seems for now we're stuck with gj/gk not preserving column position
when jumping across short lines.