Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix normal command double quote bug #9430

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

Fix normal command double quote bug #9430

Changes from all commits
Commits
Show all changes
53 commits
Select commit Hold shift + click to select a range
7cd2f3c
implement normal command temporarily
s-kai273 Feb 19, 2024
07f848a
implement normal command
s-kai273 Feb 19, 2024
f6a7cd6
implement normal command with visual mode
s-kai273 Feb 20, 2024
f384c21
modify error message
s-kai273 Feb 20, 2024
a3e2087
fix bug of undo execution after normal command with multiple lines
s-kai273 Feb 21, 2024
307258a
delete unnecessary code
s-kai273 Feb 22, 2024
8f21e22
fix bug of repeatable dot on normal command
s-kai273 Feb 22, 2024
9c1e490
fix bug of infinite loop in normal command
s-kai273 Feb 23, 2024
b227354
modify normal command to support range line
s-kai273 Feb 23, 2024
dbea00b
fix cursor position without any range
s-kai273 Feb 23, 2024
730386e
remove unnecessary file change
s-kai273 Feb 23, 2024
9bb9a85
remove unnecessary file change
s-kai273 Feb 23, 2024
255b9f4
modify normal command keystroke parser
s-kai273 Feb 24, 2024
1261062
add withRange parameter to ExecuteNormalTransformation
s-kai273 Feb 27, 2024
a01cd25
modify normal command to specify cursorStopPosition for line numbers
s-kai273 Feb 27, 2024
149946b
add simple one liner test
s-kai273 Mar 13, 2024
0ce572d
fix cursor position bug after insert mode with macro
s-kai273 Mar 13, 2024
e8a3afe
add several test cases
s-kai273 Mar 13, 2024
7fea14d
Merge branch 'master' into feature/implement_normal_command
s-kai273 Mar 14, 2024
6f64259
Merge branch 'master' into feature/implement_normal_command
J-Fields Mar 15, 2024
04500b0
modify setup code
s-kai273 Mar 28, 2024
8f09a16
modify comment
s-kai273 Mar 28, 2024
9d4d457
modify declaration of transformation attributes
s-kai273 Mar 28, 2024
283e7c6
modify TextLine list to just number list
s-kai273 Mar 28, 2024
b227f72
add test case of incomplete operation
s-kai273 Mar 28, 2024
3643304
add TODO comment of parsing :normal!
s-kai273 Mar 28, 2024
853fb47
add commented out test of stopping when operation fails
s-kai273 Mar 30, 2024
c574554
add test of undo
s-kai273 Mar 30, 2024
cb8f19f
Merge branch 'master' into feature/implement_normal_command
s-kai273 Apr 6, 2024
766ea77
use newTestSkip instead of commenting out
s-kai273 Apr 7, 2024
507c615
Merge branch 'master' into feature/implement_normal_command
J-Fields Apr 7, 2024
75ca673
Merge branch 'master' into feature/implement_normal_command
s-kai273 Apr 10, 2024
0045ac0
Merge branch 'master' into feature/implement_normal_command
s-kai273 Apr 26, 2024
66ed877
Merge branch 'master' into feature/implement_normal_command
s-kai273 May 12, 2024
a3926ed
Merge branch 'master' of github.com:s-kai273/Vim into feature/impleme…
s-kai273 May 20, 2024
dbd0bd2
Merge branch 'master' of github.com:VSCodeVim/Vim into feature/implem…
s-kai273 May 20, 2024
a67f745
modify multiple dot test not to skip
s-kai273 May 20, 2024
e4532d9
Merge branch 'master' into feature/implement_normal_command
J-Fields May 25, 2024
3149e8c
refactor normal command argparser
s-kai273 May 27, 2024
9a02ae5
refactor pushing line number of normal command execution
s-kai273 May 27, 2024
d7caafe
refactor executing escape of modeHandler
s-kai273 May 27, 2024
e70e7ea
rename keystroke to keystrokes
s-kai273 May 27, 2024
21d94d0
refactor ExecuteNormalTransformation
s-kai273 May 28, 2024
779f7c5
Merge branch 'master' into feature/implement_normal_command
s-kai273 May 28, 2024
4ee4f3d
refacor execute method
s-kai273 May 28, 2024
0838187
Merge branch 'master' into feature/implement_normal_command
J-Fields Jun 30, 2024
514ea6f
Merge branch 'feature/implement_normal_command' of github.com:s-kai27…
s-kai273 Aug 24, 2024
56ded82
Merge branch 'master' of github.com:VSCodeVim/Vim
s-kai273 Aug 24, 2024
b70a80f
Merge branch 'master' of github.com:VSCodeVim/Vim
s-kai273 Aug 25, 2024
2344d54
Merge branch 'master' of github.com:VSCodeVim/Vim
s-kai273 Sep 10, 2024
a55d0d6
fix double quote bug
s-kai273 Jan 11, 2025
4f5b4e4
Merge branch 'master' into feature/fix_normal_command_double_quote_bug
s-kai273 Jan 11, 2025
9b43fa1
Merge branch 'master' into feature/fix_normal_command_double_quote_bug
s-kai273 Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vimscript/parserUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ const escapedParser = string('\\')
export const keystrokesExpressionParser: Parser<string[]> = alt(
escapedParser,
specialCharacterParser,
noneOf('"'),
regexp(/./),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the use of noneOf('"'), parsing parameters that contain double quotes fails.
However, I believe that including double quotes is not an invalid case in normal command.

If replacing the original parser with regexp(/./) introduces other issues, please let me know!

).many();

export const keystrokesExpressionForMacroParser: Parser<string[]> = alt(
Expand Down