Fix Python async function motions with async def
#9511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
fixes Python function motions
[mand]mto recognizeasync defWhich issue(s) this PR fixes
fixes #9510
Additional notes
i opted to keep old tests and introduce new.
in this process, i found a bug related to function boundaries, captured in "valid findPrevFunctionStart, from inner regular to outer async" and "valid findPrevFunctionStart, from inner async to inner regular".
The bug was that when searching backwards for function boundaries, the original code would include the current function in the results because isBefore() returns true for equal positions, causing the motion to incorrectly stay at the current function instead of moving to the previous one. the original tests didn't have any test cases for moving backwards from within a function definition line itself.