Merge pull request #51 from Vannevelj/37-newguid

Fixes #37
Vannevelj · Apr 13, 2020 · 1a48859 · 1a48859
2 parents b73a38a + f5bafae
commit 1a48859
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/sharpsource/sharpsource.Test/NewGuidTests.cs b/sharpsource/sharpsource.Test/NewGuidTests.cs
@@ -230,5 +230,24 @@ void Method()
 
             VerifyDiagnostic(original);
         }
+
+        [TestMethod]
+        public void NewGuid_OverloadedConstructor()
+        {
+            var original = @"
+using System;
+namespace ConsoleApplication1
+{
+    class MyClass
+    {
+        void Method()
+        {
+            Guid g = new Guid(string.Empty);
+        }
+    }
+}";
+
+            VerifyDiagnostic(original);
+        }
     }
 }
diff --git a/sharpsource/sharpsource/Diagnostics/NewGuid/NewGuidAnalyzer.cs b/sharpsource/sharpsource/Diagnostics/NewGuid/NewGuidAnalyzer.cs
@@ -29,6 +29,7 @@ private static void AnalyzeSymbol(SyntaxNodeAnalysisContext context)
 
             if (symbol != null &&
                 symbol.Name == "Guid" &&
+                expression.ArgumentList?.Arguments.Any() != true &&
                 ( symbol.ContainingAssembly.Name == "mscorlib" || symbol.ContainingAssembly.Name == "System.Runtime" ))
             {
                 context.ReportDiagnostic(Diagnostic.Create(Rule, context.Node.GetLocation()));