Fix bug where enums with underlying types would cause a crash #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just tested with negative values and it does not work. |
Add test for negative value + different underlying type
Vannevelj
reviewed
Sep 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a unit test to demonstrate the issue. The pattern-based check in EnumWithoutDefaultValueAnalyzer.cs:49 only works when the enum is using its default underlying type (int). When it is any other numerical type (byte, short, ushort, uint, long or ulong) it crashes due to an invalid cast.
Convert.ToULong()works because it uses the IConvertible interface on the numerical types to convert between values, and usingToUlong()instead of f.ex.ToInt()means we don't have to check for all possible types, since we are only interested in if the value is 0.