Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Target sequence categories #35

Closed
afrubin opened this issue Apr 5, 2023 · 1 comment · Fixed by VariantEffect/mavedb-ui#315, #352, VariantEffect/dcd_mapping2#28 or #362
Closed

Target sequence categories #35

afrubin opened this issue Apr 5, 2023 · 1 comment · Fixed by VariantEffect/mavedb-ui#315, #352, VariantEffect/dcd_mapping2#28 or #362
Assignees
@bencap
Labels
app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend type: enhancement Enhancement to an existing feature type: maintenance Maintaining this project

Comments

@afrubin
Copy link
Member

afrubin commented Apr 5, 2023

The target category names are not very API-like. I propose changing them to "protein_coding" "regulatory" and "other_noncoding" for their internal representation and using the text provided in the UI.

mavedb-api/src/mavedb/lib/validation/constants/target.py

Line 1 in 61c3114

valid_categories = ["Protein coding", "Regulatory", "Other noncoding"]

jstone-dev added a commit that referenced this issue Aug 26, 2024
@jstone-dev
Calculate score set statistics and expose in API. (#35)
eec57f0
@bencap bencap added type: enhancement Enhancement to an existing feature type: maintenance Maintaining this project labels Aug 27, 2024
@bencap bencap added app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend labels Oct 1, 2024
@bencap
Copy link
Collaborator

bencap commented Oct 7, 2024

Note we will need to adjust mapper return values, and double check how front end code is displayed.

@bencap bencap self-assigned this Nov 1, 2024
bencap added a commit that referenced this issue Nov 4, 2024
@bencap
Alembic Migration for #35
a284673
This was linked to pull requests Nov 4, 2024
Display Target Categories in a User Friendly Way VariantEffect/mavedb-ui#315
Merged
Target Category Constant #352
Merged
@bencap bencap linked a pull request Nov 13, 2024 that will close this issue
New API values for protein categories VariantEffect/dcd_mapping2#28
Merged
This was referenced Nov 20, 2024
Merged
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bencap bencap

Labels
app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend type: enhancement Enhancement to an existing feature type: maintenance Maintaining this project
Projects
None yet
Milestone
No milestone
2 participants
@afrubin @bencap