Not showing meta-analysis experiments in creating score set dropdown menu. #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencap
requested changes
Dec 10, 2024
| @@ -43,45 +43,6 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| # TODO: Rewrite this function. | |||
There was a problem hiding this comment.
Lets retain this function-- I think it still has utility for just listing all experiments.
There was a problem hiding this comment.
Sure. I'll modify it so that we don't need to send the weird q to it.
There was a problem hiding this comment.
I think it is ok to just leave it as is for this PR so we can get it released. We can just handle it at some point later-- it isn't hurting anything right now.
bencap
approved these changes
Jan 7, 2025
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API codes for VariantEffect/mavedb-ui#296