Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Only allow users to autocomplete with their own target genes #273

Closed
bencap opened this issue Sep 16, 2024 · 1 comment · Fixed by VariantEffect/mavedb-api#341, #307 or #321
Closed

Only allow users to autocomplete with their own target genes #273

bencap opened this issue Sep 16, 2024 · 1 comment · Fixed by VariantEffect/mavedb-api#341, #307 or #321
Assignees
@jstone-dev
Labels
app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend type: enhancement Enhancement to an existing feature

Comments

@bencap
Copy link
Collaborator

bencap commented Sep 16, 2024

Autocompleting via the global MaveDB target gene space may be somewhat error prone and lead to behavior our users do not expect. They are much more likely to be familiar with their own target genes, and those target genes are also substantially more likely to actually be relevant to their data.
@bencap bencap added the type: enhancement Enhancement to an existing feature label Sep 16, 2024
@bencap bencap added app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend labels Oct 1, 2024
@bencap
Copy link
Collaborator Author

bencap commented Oct 7, 2024

Every target is a copy of the autocompleted target. This means there is a lot of duplication of targets in our database. Might we want to de-duplicate targets for a user when there are many?

This was linked to pull requests Oct 23, 2024
User-specific target gene search VariantEffect/mavedb-api#341
Merged
Limit “copy from existing target gene” to the user’s own target genes. #307
Merged
This was referenced Nov 20, 2024
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@jstone-dev jstone-dev

Labels
app: backend Task implementation touches the backend app: frontend Task implementation touches the frontend type: enhancement Enhancement to an existing feature
Projects
None yet
Milestone
No milestone
2 participants
@bencap @jstone-dev