Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Limit “copy from existing target gene” to the user’s own target genes. #307

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jstone-dev
Copy link
Collaborator

This UI change depends on VariantEffect/mavedb-api#341.

@jstone-dev jstone-dev marked this pull request as ready for review October 21, 2024 21:53
@@ -237,7 +237,7 @@ const itemTypes = {
httpOptions: {
list: {
method: 'post',
url: `${config.apiBaseUrl}/target-genes/search`
url: `${config.apiBaseUrl}/me/target-genes/search`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps worth it to change the item type name too to be clear about being the users' own target genes when we construct the item?

@bencap bencap linked an issue Oct 23, 2024 that may be closed by this pull request
@bencap bencap merged commit c0d6ac9 into release-2024.4.2 Nov 18, 2024
@bencap bencap deleted the jstone-dev/273/target-gene-autocompletion branch November 20, 2024 21:45
@bencap bencap mentioned this pull request Nov 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only allow users to autocomplete with their own target genes
2 participants