Estelle/controlled keywords #243
Conversation
…on. Other functions work normally.
…ontrolledKeywords
… back when we get final keywords list.
| @@ -541,7 +752,7 @@ export default { | |||
| } | |||
|
|
|||
| const editedItem = _.merge({}, this.item || {}, editedFields) | |||
|
|
|||
| console.log(editedItem) | |||
There was a problem hiding this comment.
Agree. I think I added it when I debug something and forgot it.
| <p class="m-0"> | ||
| {{ keyword.keyword.description }} | ||
| </p> | ||
| </Dialog> : <a :href="`https://www.mavedb.org/search/?keywords=${keyword.keyword.value}`">{{ keyword.keyword.value }}</a> |
There was a problem hiding this comment.
It doesn't seem like there is a mechanism in the score set search to search by keywords on associated experiments. We either want to add that or remove this link, since right now it will just link to a generic search when clicked.
There was a problem hiding this comment.
In search_score_set function, I added this part. My understanding for it is the associated score sets will be returned if users type keywords. However, it's online one so I can't test it and I thought just put it first and see how it's going.
There was a problem hiding this comment.
I think that will allow us to load the score sets matching our filter logic, but we would still need to add the filter for keywords and add the .
So in src/mavedb/view_models/search.py we would need to add a keywords list to the search model:
class ScoreSetsSearch(BaseModel):
published: Optional[bool]
targets: Optional[list[str]]
target_organism_names: Optional[list[str]]
target_types: Optional[list[str]]
target_accessions: Optional[list[str]]
authors: Optional[list[str]]
databases: Optional[list[str]]
journals: Optional[list[str]]
publication_identifiers: Optional[list[str]]
keywords: Optional[list[str]]
text: Optional[str]
And then in src/mavedb/lib/score_sets.py we'd have to add a block that queries the experiment keywords:
if search.keywords:
query = query.filter(
Experiment.keyword_objs.any(
ControlledKeyword.value.in_(search.keywords)
)
)
I haven't tested that, but would be happy to look together if you wanted to add it in.
Finished one.