Extend FFmpeg support from 4.0 - 4.2 to 4.0 - 4.5/5.0 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
feature/ffmpeg-4.4
branch
2 times, most recently
from
3981907
to
e9ea6c7
Compare
…g 4.2 When FFmpeg Encoders was originally written, FFmpeg 4.2 was still new and OBS Studio did not seem to want to update to anything newer for a while. This led to code being fine-tuned for FFmpeg 4.2, which stops working the moment OBS Studio upgrades FFmpeg. This removes the dependency on FFmpeg 4.2 hopefully, and allows using newer FFmpeg versions - or perhaps even older versions. Additionally the nonsensical behavior of the Target Quality slider was fixed. It is now from 0 to 51, instead of from 0 to 100, and as such matches FFmpeg exactly.
Xaymar
force-pushed
the
feature/ffmpeg-4.4
branch
from
e9ea6c7
to
a358f67
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
When FFmpeg Encoders was designed, it was designed for FFmpeg 4.2, which means that a lot of code only works with that specific version of FFmpeg. This has now come around to bite us in the back, as OBS Studio updated their FFmpeg version to something newer than 4.4, and as such the new SDK features are now enabled by default. This PR brings support for any FFmpeg version between 4.0 and 5.0, hopefully.
Related Issues
Checklist