Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

templates/windows/installer: Implement /Portable installer flag for CLI users #935

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

Xaymar
Copy link
Contributor

@Xaymar Xaymar commented Sep 19, 2022

Explain the Pull Request

Implements a /Portable flag which will properly switch the Installer into Portable mode as expected when run from CLI.

Completion Checklist

  • I have added myself to the Copyright and License headers and files.
  • I will maintain this code in the future and have added myself to CODEOWNERS.
  • I have tested this change on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11

@Xaymar
Copy link
Contributor Author

Xaymar commented Sep 19, 2022

@ImportTaste Test builds are available in the Checks tab, if you wish to test the new installer.

@Xaymar Xaymar changed the title Implement /Portable installer flag for CLI users templates/windows/installer: Implement /Portable installer flag for CLI users Sep 19, 2022
…llation

Users of the Installer can now specify the `/Portable` flag in addition to other flags to install as Portable.
@Xaymar Xaymar force-pushed the patch/windows-bundle-portable-cli branch from ca13e6d to e9f68d2 Compare September 19, 2022 23:16
@Xaymar Xaymar merged commit fbc95fb into master Sep 20, 2022
@Xaymar Xaymar deleted the patch/windows-bundle-portable-cli branch September 20, 2022 00:11
@Xaymar
Copy link
Contributor Author

Xaymar commented Sep 20, 2022

Tested in combination with previous PR.

@God-damnit-all
Copy link

God-damnit-all commented Sep 20, 2022

It works! One minor nitpick, not something I'm sure can even be avoided without a major rework - the /CURRENTUSER flag is still required to do a CLI install. Looking at the code, I presume /ALLUSERS would work the same way.

But, I don't really care about that, it's not a big deal. I'm mainly mentioning it in case anyone else has issues. (And another thing for them to know is that, while it does create an uninstaller executable, it does not create any install information in "Add or remove programs", i.e. the registry, as intended. It's just there to delete the files specific to StreamFX.)

For reference, this is the command I ran:

streamfx-windows-blahblahblah.exe /VERYSILENT /CURRENTUSER /DIR="DriveLetter:\DirectoryThatDoesntNeedToAlreadyExist" /Portable

Anyhow, thank you for doing this.

@Xaymar
Copy link
Contributor Author

Xaymar commented Sep 20, 2022

Yes, you'll still need to specify that you wish to install as the current user. This is a restriction of InnoSetup, and not something I can affect without writing a completely new installer. For obvious reasons, I'm not interested in writing a new installer.

@God-damnit-all
Copy link

Yes, you'll still need to specify that you wish to install as the current user. This is a restriction of InnoSetup, and not something I can affect without writing a completely new installer. For obvious reasons, I'm not interested in writing a new installer.

I figured as much. Thanks again for adding the /Portable parameter.

@Xaymar Xaymar added this to the 0.12 milestone Mar 18, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants