Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add reducer tracing to errors #409

Merged
merged 3 commits into from
Aug 31, 2019

Conversation

acatl
Copy link
Collaborator

@acatl acatl commented Aug 29, 2019

What:

Exposes a reducerStackTrace when an error occurs on the execution of any reducer.

Why:

To help us debug errors and follow the trace of reducers executed.

Checklist:

  • Has Breaking changes
  • Documentation
  • Tests
  • Ready to be merged
  • Added username to all-contributors list

Notice reducerStackTrace error property being logged:

image

acatl added 2 commits August 29, 2019 16:59
error.reducerStackTrace now contains a stack trace of all reducers executed before and including the
reducer with the error
@acatl acatl added this to the v6 Instrumentation milestone Aug 29, 2019
@acatl acatl requested review from raingerber and csarnataro August 29, 2019 21:16
@acatl acatl self-assigned this Aug 29, 2019
@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #409 into canary will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           canary   #409   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          23     23           
  Lines         381    387    +6     
  Branches       56     57    +1     
=====================================
+ Hits          381    387    +6
Impacted Files Coverage Δ
packages/data-point/src/Accumulator.js 100% <100%> (ø) ⬆️
packages/data-point/src/resolve.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8728c29...4360c45. Read the comment docs.

@acatl acatl merged commit 23cf880 into ViacomInc:canary Aug 31, 2019
@acatl acatl deleted the add-reducer-tracing-to-errors branch August 31, 2019 15:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants