vmsingle: release 0.14.3, fixes #2037

VictoriaMetrics · Mar 3, 2025 · 6214876 · 6214876
1 parent 44c62d7
commit 6214876
Show file tree

Hide file tree

Showing 5 changed files with 75 additions and 43 deletions.
diff --git a/charts/victoria-metrics-single/CHANGELOG.md b/charts/victoria-metrics-single/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## Next release
 
-- TODO
+- Set default mode back to statefulSet. See [this issue](https://github.com/VictoriaMetrics/helm-charts/issues/2037).
 
 ## 0.14.2
 

diff --git a/charts/victoria-metrics-single/Chart.yaml b/charts/victoria-metrics-single/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 type: application
 description: Victoria Metrics Single version - high-performance, cost-effective and scalable TSDB, long-term remote storage for Prometheus
 name: victoria-metrics-single
-version: 0.14.2
+version: 0.14.3
 appVersion: v1.112.0
 sources:
   - https://github.com/VictoriaMetrics/helm-charts

diff --git a/charts/victoria-metrics-single/tests/__snapshot__/server_test.yaml.snap b/charts/victoria-metrics-single/tests/__snapshot__/server_test.yaml.snap
@@ -1,7 +1,7 @@
 deployment should match snapshot:
   1: |
     apiVersion: apps/v1
-    kind: Deployment
+    kind: StatefulSet
     metadata:
       labels:
         app: server
@@ -13,14 +13,14 @@ deployment should match snapshot:
       name: RELEASE-NAME-victoria-metrics-single-server
       namespace: NAMESPACE
     spec:
+      podManagementPolicy: OrderedReady
       replicas: 1
       selector:
         matchLabels:
           app: server
           app.kubernetes.io/instance: RELEASE-NAME
           app.kubernetes.io/name: victoria-metrics-single
-      strategy:
-        type: Recreate
+      serviceName: RELEASE-NAME-victoria-metrics-single-server
       template:
         metadata:
           labels:
@@ -69,14 +69,23 @@ deployment should match snapshot:
           securityContext: {}
           serviceAccountName: RELEASE-NAME-victoria-metrics-single-server
           terminationGracePeriodSeconds: 60
-          volumes:
-            - name: server-volume
-              persistentVolumeClaim:
-                claimName: RELEASE-NAME-victoria-metrics-single-server
+          volumes: null
+      updateStrategy: {}
+      volumeClaimTemplates:
+        - apiVersion: v1
+          kind: PersistentVolumeClaim
+          metadata:
+            name: server-volume
+          spec:
+            accessModes:
+              - ReadWriteOnce
+            resources:
+              requests:
+                storage: 16Gi
 deployment with volume should match snapshot:
   1: |
     apiVersion: apps/v1
-    kind: Deployment
+    kind: StatefulSet
     metadata:
       labels:
         app: server
@@ -88,14 +97,14 @@ deployment with volume should match snapshot:
       name: RELEASE-NAME-victoria-metrics-single-server
       namespace: NAMESPACE
     spec:
+      podManagementPolicy: OrderedReady
       replicas: 1
       selector:
         matchLabels:
           app: server
           app.kubernetes.io/instance: RELEASE-NAME
           app.kubernetes.io/name: victoria-metrics-single
-      strategy:
-        type: Recreate
+      serviceName: RELEASE-NAME-victoria-metrics-single-server
       template:
         metadata:
           labels:
@@ -144,14 +153,23 @@ deployment with volume should match snapshot:
           securityContext: {}
           serviceAccountName: RELEASE-NAME-victoria-metrics-single-server
           terminationGracePeriodSeconds: 60
-          volumes:
-            - name: server-volume
-              persistentVolumeClaim:
-                claimName: RELEASE-NAME-victoria-metrics-single-server
-statefulset should match snapshot:
+          volumes: null
+      updateStrategy: {}
+      volumeClaimTemplates:
+        - apiVersion: v1
+          kind: PersistentVolumeClaim
+          metadata:
+            name: server-volume
+          spec:
+            accessModes:
+              - ReadWriteOnce
+            resources:
+              requests:
+                storage: 16Gi
+statefulSet should match snapshot:
   1: |
     apiVersion: apps/v1
-    kind: Deployment
+    kind: StatefulSet
     metadata:
       labels:
         app: server
@@ -163,14 +181,14 @@ statefulset should match snapshot:
       name: RELEASE-NAME-victoria-metrics-single-server
       namespace: NAMESPACE
     spec:
+      podManagementPolicy: OrderedReady
       replicas: 1
       selector:
         matchLabels:
           app: server
           app.kubernetes.io/instance: RELEASE-NAME
           app.kubernetes.io/name: victoria-metrics-single
-      strategy:
-        type: Recreate
+      serviceName: RELEASE-NAME-victoria-metrics-single-server
       template:
         metadata:
           labels:
@@ -219,14 +237,23 @@ statefulset should match snapshot:
           securityContext: {}
           serviceAccountName: RELEASE-NAME-victoria-metrics-single-server
           terminationGracePeriodSeconds: 60
-          volumes:
-            - name: server-volume
-              persistentVolumeClaim:
-                claimName: RELEASE-NAME-victoria-metrics-single-server
-statefulset with volume should match snapshot:
+          volumes: null
+      updateStrategy: {}
+      volumeClaimTemplates:
+        - apiVersion: v1
+          kind: PersistentVolumeClaim
+          metadata:
+            name: server-volume
+          spec:
+            accessModes:
+              - ReadWriteOnce
+            resources:
+              requests:
+                storage: 16Gi
+statefulSet with volume should match snapshot:
   1: |
     apiVersion: apps/v1
-    kind: Deployment
+    kind: StatefulSet
     metadata:
       labels:
         app: server
@@ -238,14 +265,14 @@ statefulset with volume should match snapshot:
       name: RELEASE-NAME-victoria-metrics-single-server
       namespace: NAMESPACE
     spec:
+      podManagementPolicy: OrderedReady
       replicas: 1
       selector:
         matchLabels:
           app: server
           app.kubernetes.io/instance: RELEASE-NAME
           app.kubernetes.io/name: victoria-metrics-single
-      strategy:
-        type: Recreate
+      serviceName: RELEASE-NAME-victoria-metrics-single-server
       template:
         metadata:
           labels:
@@ -294,7 +321,16 @@ statefulset with volume should match snapshot:
           securityContext: {}
           serviceAccountName: RELEASE-NAME-victoria-metrics-single-server
           terminationGracePeriodSeconds: 60
-          volumes:
-            - name: server-volume
-              persistentVolumeClaim:
-                claimName: RELEASE-NAME-victoria-metrics-single-server
+          volumes: null
+      updateStrategy: {}
+      volumeClaimTemplates:
+        - apiVersion: v1
+          kind: PersistentVolumeClaim
+          metadata:
+            name: server-volume
+          spec:
+            accessModes:
+              - ReadWriteOnce
+            resources:
+              requests:
+                storage: 16Gi
diff --git a/charts/victoria-metrics-single/tests/server_test.yaml b/charts/victoria-metrics-single/tests/server_test.yaml
@@ -5,36 +5,32 @@ chart:
 templates:
   - server.yaml
 tests:
-  - it: deployment should match snapshot
+  - it: statefulSet should match snapshot
     asserts:
       - matchSnapshot: {}
     set:
       remoteWrite:
         - url: http://vm-insert:8480/insert/0/prometheus
-  - it: deployment with volume should match snapshot
+  - it: statefulSet with volume should match snapshot
     asserts:
       - matchSnapshot: {}
     set:
       persistentVolume:
         enabled: true
       remoteWrite:
         - url: http://vm-insert:8480/insert/0/prometheus
-  - it: statefulset should match snapshot
+  - it: deployment should match snapshot
     set:
-      statefulSet:
-        enabled: true
-      mode: statefulSet
+      mode: deployment
       remoteWrite:
         - url: http://vm-insert:8480/insert/0/prometheus
     asserts:
       - matchSnapshot: {}
-  - it: statefulset with volume should match snapshot
+  - it: deployment with volume should match snapshot
     set:
-      statefulSet:
-        enabled: true
+      mode: statefulSet
       persistentVolume:
         enabled: true
-      mode: statefulSet
       remoteWrite:
         - url: http://vm-insert:8480/insert/0/prometheus
     asserts:

diff --git a/charts/victoria-metrics-single/values.yaml b/charts/victoria-metrics-single/values.yaml
@@ -376,7 +376,7 @@ server:
     ipFamilies: []
 
   # -- VictoriaMetrics mode: deployment, statefulSet
-  mode: deployment
+  mode: statefulSet
 
   # -- [K8s Deployment](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/) specific variables
   deployment: