Skip to content

Commit

Permalink
test/e2e: remove flaky expectExpanding check
Browse files Browse the repository at this point in the history
Signed-off-by: f41gh7 <nik@victoriametrics.com>
  • Loading branch information
f41gh7 committed Mar 4, 2025
1 parent a525e3f commit 68cc43d
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 13 deletions.
3 changes: 0 additions & 3 deletions test/e2e/vmagent_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,6 @@ var _ = Describe("test vmagent Controller", func() {
step.modify(&toUpdate)
return k8sClient.Update(ctx, &toUpdate)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusExpanding(ctx, k8sClient, &v1beta1vm.VMAgent{}, namespacedName)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusOperational(ctx, k8sClient, &v1beta1vm.VMAgent{}, namespacedName)
}, eventualStatefulsetAppReadyTimeout).Should(Succeed())
Expand Down
3 changes: 0 additions & 3 deletions test/e2e/vmalert_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -219,9 +219,6 @@ var _ = Describe("test vmalert Controller", func() {
modify(&toUpdate)
return k8sClient.Update(ctx, &toUpdate)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusExpanding(ctx, k8sClient, &v1beta1vm.VMAlert{}, namespacedName)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusOperational(ctx, k8sClient, &v1beta1vm.VMAlert{}, namespacedName)
}, eventualStatefulsetAppReadyTimeout).Should(Succeed())
Expand Down
3 changes: 0 additions & 3 deletions test/e2e/vmauth_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,6 @@ var _ = Describe("test vmauth Controller", func() {
step.modify(&toUpdate)
return k8sClient.Update(ctx, &toUpdate)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusExpanding(ctx, k8sClient, &v1beta1vm.VMAuth{}, namespacedName)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusOperational(ctx, k8sClient, &v1beta1vm.VMAuth{}, namespacedName)
}, eventualDeploymentAppReadyTimeout).Should(Succeed())
Expand Down
4 changes: 0 additions & 4 deletions test/e2e/vmsingle_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,10 +314,6 @@ var _ = Describe("test vmsingle Controller", func() {
step.modify(&toUpdate)
return k8sClient.Update(ctx, &toUpdate)
}, eventualExpandingTimeout).Should(Succeed())
Eventually(func() error {
return expectObjectStatusExpanding(ctx, k8sClient, &vmv1beta1.VMSingle{}, namespacedName)
}, eventualExpandingTimeout).Should(Succeed())

Eventually(func() error {
return expectObjectStatusOperational(ctx, k8sClient, &vmv1beta1.VMSingle{}, namespacedName)
}, eventualDeploymentAppReadyTimeout).Should(Succeed())
Expand Down

0 comments on commit 68cc43d

Please # to comment.