vmuser: fix reconciling the vmauth config #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebensom
requested review from
f41gh7,
Haleygo and
AndrewChubatiuk
as code owners
|
@f41gh7 Can you please review this small bugfix? |
|
@f41gh7 it seems like one unrelated unit test failed due to an unknown reason (flaky test maybe?). Could you please re-run the GH action and merge the PR? I don't have permission. |
|
Thanks for contribution!
No worries, It's flaky e2e test. We're going to fix it at some point ( it was a choice between speed and reliability, we choose speed). |
|
Bugfix included into v0.53.0 release |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a logic bug in
VMAuth.IsUnmanaged(), the VMUser reconiliation does not update the corresponding VMAuth resources' configuration:https://github.com/VictoriaMetrics/operator/blob/master/internal/controller/operator/vmuser_controller.go#L99
This bug is hidden/mitigated currently because the VMAuth reconciliation by default is requeued every 60 seconds:
https://github.com/VictoriaMetrics/operator/blob/master/internal/controller/operator/vmauth_controller.go#L101