Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

{make,ci}: publish images to both docker and quay #1250

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

zekker6
Copy link
Contributor

@zekker6 zekker6 commented Feb 26, 2025

Updates workflows and release tasks for make to push images to both quay and dockerhub.

See: VictoriaMetrics/VictoriaMetrics#4116

@zekker6 zekker6 marked this pull request as ready for review February 26, 2025 13:29
@AndrewChubatiuk
Copy link
Contributor

@zekker6
have you added this secret to github?

@zekker6
Copy link
Contributor Author

zekker6 commented Feb 26, 2025

@AndrewChubatiuk Yes, secrets were created. Running a test to confirm that it works end to end in 87fcfc5

@zekker6 zekker6 marked this pull request as draft February 26, 2025 13:47
@AndrewChubatiuk
Copy link
Contributor

need to disable e2e tests to check, they are failing with a high probability now

Copy link
Contributor

@AndrewChubatiuk AndrewChubatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zekker6 zekker6 marked this pull request as ready for review February 26, 2025 14:03
@zekker6 zekker6 merged commit 1975077 into master Feb 26, 2025
5 of 8 checks passed
@zekker6 zekker6 deleted the ci-quay-repo branch February 26, 2025 14:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants