-
Notifications
You must be signed in to change notification settings - Fork 2
Dev #137
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Open
Samuel-amap
wants to merge
37
commits into
main
Choose a base branch
from
dev
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype issues remaining
…sage gain on the XPalm side). Currently deactivated. Some details will need fixing, many tests will be broken (for both PSE and XPalm), documentation not up-to-date
…tputs. Should probably document some of the differences with single-scale conversion (CSV friendly, no refvectors)
…anup still required.
… approach as the previous output preallocation function), to fix test-mtg in PBP, the only test making use of MutableNodeMTG
…s now pass for PSE, XPalm and PBP. Performance should be adequate, to be confirmed, possible light loss for XPalm. Benchmarks and documentation still need work.
…nstream folder, let's uh, remove it from the repo
…e got renamed from XPalm.jl to XPalm ? I had to tinker with my local repo at some point, I think that's why)
…ng the other stuff
…'s own dev branches, see what happens
…nt dependency issue ?
…ster in the manifest, attempt to resolve when PSE is activated
…ully ensure there are no registry/manifest conflicts. The removed lingering manifest.toml in the repo might have been both causing and hiding conflicts.
…ding PBP and XPalm dev branches), we'll see what happens when merging this into dev
…t_rework Multiscale outputs struct rework
…ne doesn't always work (was getting some PackageName#dev#main on the GH action side of things, instead of PackageName#dev), possibly causing issues
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a new intermediary branch to test some non-regression benchmarks setup. Might be susceptible to change.