Add scala-cli version to the BuildInfo #3617
Open
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gedochao Here is the PR for adding scala-cli version to buildInfo. Could you please review? |
Gedochao
reviewed
Apr 4, 2025
modules/options/src/main/scala/scala/build/info/BuildInfo.scala
Outdated
Show resolved
Hide resolved
| @@ -51,6 +51,8 @@ object BuildInfo { | |||
| val mainClass = Some("Main") | |||
| /** Project version */ | |||
| val projectVersion = None | |||
| /** Scala-cli version used for the compilation */ | |||
| val scalaCliVersion = Some("1.1.1-SNAPSHOT") | |||
There was a problem hiding this comment.
mental note, that this doc should get updated with some more modern values =)
Suggested change
| val scalaCliVersion = Some("1.1.1-SNAPSHOT") | |
| val scalaCliVersion = Some("1.7.1") |
There was a problem hiding this comment.
@Gedochao I fixed the tests in SourceGeneratorTests, I hope that is the only place.
Also, since the constants file was not accessible there, i hardcoded the version 1.1.1-SNAPSHOT in the test. Is it ok?
There was a problem hiding this comment.
@Gedochao Could you review this once again. I think there are some test failures, will have a look at it once again. But is the other changes ok?
Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
…van88/scala-cli into buildinfo-scala-cli-version
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a variable for the scalaCliVersion in the generated BuildInfo