-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support for parsing anchor/tag in mapping #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
simple-tokens
branch
from
November 12, 2021 21:28
c469d14
to
c4e93b6
Compare
lwronski
force-pushed
the
simple-tokens
branch
from
November 12, 2021 21:54
c4e93b6
to
34ceaa6
Compare
kpodsiad
approved these changes
Nov 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments will be very welcome but otherwise looks good
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/ReaderCtx.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/Tokenizer.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/Tokenizer.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/ReaderCtx.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/ReaderCtx.scala
Outdated
Show resolved
Hide resolved
kpodsiad
reviewed
Nov 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add more tests where there are anchor and tag next to each other, especially when they are attributes of mapping key
lwronski
force-pushed
the
simple-tokens
branch
from
November 13, 2021 09:15
2393d74
to
2f5a746
Compare
lwronski
force-pushed
the
simple-tokens
branch
from
November 13, 2021 10:01
6d9be77
to
e6009f3
Compare
kpodsiad
approved these changes
Nov 13, 2021
yaml/shared/src/main/scala/org/virtuslab/yaml/internal/load/reader/ReaderCtx.scala
Outdated
Show resolved
Hide resolved
yaml/shared/src/test/scala/org/virtuslab/yaml/tokenizer/TagSuite.scala
Outdated
Show resolved
Hide resolved
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.