Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

docs(vignette): Integrate MSstats workflow into vignette and test data #13

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Aug 27, 2024

Motivation and Context

Based on bioc feedback, there was no clear relationship between the MSstats workflow and MSstatsBioNet. This PR attempts to integrate the two workflows into the MSstatsBioNet vignette.

Changes

  • Add MSstatsConvert and MSstats workflows into MSstatsBioNet vignette
  • Move data to /inst/extdata directory
  • Add script demonstrating how to create dataset in /inst/extdata directory
  • Update documentation

Testing

  • Unit tests have been updated and pass
  • RMD check passes

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999 tonywu1999 merged commit d173527 into devel Aug 27, 2024
3 checks passed
@tonywu1999 tonywu1999 deleted the msstats branch August 27, 2024 19:54
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (f8aa0f8) to head (a09b9bd).
Report is 2 commits behind head on devel.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel      #13      +/-   ##
==========================================
+ Coverage   87.50%   87.61%   +0.11%     
==========================================
  Files           3        3              
  Lines         104      105       +1     
==========================================
+ Hits           91       92       +1     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants