-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adding Plotly feature to MSstatsPTM with Error Handling #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new Plotly library to MSstatsPTM to render Plotly plots back to MSstatsShiny app. The new parameter isPlotly to dataProcessPlotsPTM and groupComparisonPlotsPTM function handles this. If isPlotly is set to FALSE, it behaves normally (renders ggPlots).
In git diff, all the lines in the files appears to be changed. Devon and I identified this problem as issues with line endings. Below is a possible approach to fix it
There is this homebrew package dos2unix that converts file endings to what we need. Here is a test that I did
devel
calledtest-1
and applied thisdos2unix
package onR/dataProcessPlotsPTM.R
https://github.com/Vitek-Lab/MSstatsPTM/compare/devel...test-1?expand=1 It shows all the lines have changed because we have converted the line endingstest-2
which is checked out fromtest-1
and then made a small line change to verify git recognizes only that line has changed and it works https://github.com/Vitek-Lab/MSstatsPTM/compare/test-1...test-2?expand=1dos2unix
and then checkout into the feature branch to make changes