Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding Plotly feature to MSstatsPTM with Error Handling #91

Merged
merged 19 commits into from
Mar 5, 2025

Conversation

deril2605
Copy link
Contributor

@deril2605 deril2605 commented May 20, 2024

Adding new Plotly library to MSstatsPTM to render Plotly plots back to MSstatsShiny app. The new parameter isPlotly to dataProcessPlotsPTM and groupComparisonPlotsPTM function handles this. If isPlotly is set to FALSE, it behaves normally (renders ggPlots).

In git diff, all the lines in the files appears to be changed. Devon and I identified this problem as issues with line endings. Below is a possible approach to fix it

There is this homebrew package dos2unix that converts file endings to what we need. Here is a test that I did

@deril2605 deril2605 self-assigned this May 20, 2024
@devonjkohler devonjkohler merged commit c18fb1c into devel Mar 5, 2025
1 check failed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants