Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(groupComparisonPTM): Fix unit test to expect warning due to tech replicates #96

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

tonywu1999
Copy link
Contributor

@tonywu1999 tonywu1999 commented Sep 6, 2024

Motivation and Context

This change caused this PTM unit test to fail because the change caused the MSstats code to use a linear mixed effects model with an additional random effect w.r.t. GROUP:SUBJECT pairings (via the introduction of technical replicates). This causes the model to run out of degrees of freedom for cases where number of samples is low overall, generating warnings (it's a little more complicated than number of samples but basically we lose degrees of freedom with the introduction of an additional random effect).

Changes

  • Remove proteins from datasets (raw.input and summary.data) where degrees of freedom run out. Notably the 4 proteins in the PTM dataset:
    • Q9UNN5_K163
    • Q9UNS2_K179
    • Q9Y3I0_K492
    • Q9Y490_K2115

Testing

  • Dry run passes
  • Tests pass locally when using latest version of MSstats
    • We should push this change to MSstatsPTM before pushing MSstats to bioconductor.

Checklist Before Requesting a Review

  • I have read the MSstats contributing guidelines
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@tonywu1999 tonywu1999 requested a review from mstaniak September 7, 2024 01:37
@tonywu1999 tonywu1999 merged commit 34683fe into devel Sep 13, 2024
1 check passed
@tonywu1999 tonywu1999 deleted the fix-test branch September 13, 2024 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant