Modal plugin improvements #27
Comments
|
May I also request adding the |
|
@mayankgureja Sorry! I didn't see your reply. Of course, that's a great suggestion! Edit: Never mind, I'm just blind 😄 |
`.bind()` is not identical when used more than once. This means `removeEventListener` will not remove the event. Instead a common 'bound' variable needs to be created to handle both the add and remove listener calls.
`.bind()` is not identical when used more than once. This means `removeEventListener` will not remove the event. Instead a common 'bound' variable needs to be created to handle both the add and remove listener calls.
|
The improvements to the modal plugin are still a work in progress, the documentation needs to be updated along with some code cleanup. If you would like to try out the updated modal please download the feature/modal branch. All feedback is appreciated, once I'm happy with the docs and code this will be merged into master. Please note the docs are still a WIP so if you would like to try this out you'll need to look through the code to see the available options etc. If you have any bugs or ideas please reply to this issue. PRs on the feature/modal branch are also appreciated. |
|
Fixed in master. Due for release in 0.7.0 |
`.bind()` is not identical when used more than once. This means `removeEventListener` will not remove the event. Instead a common 'bound' variable needs to be created to handle both the add and remove listener calls.
The modal has no 'proper' way to create it within Javascript. There should be a way to create a modal with a title, content, confirm button and cancel button. Along with the relevant callbacks (#8).
closeButtonevent is not removed when the modal is destroyed.is-clippedclass to the html/body element when the modal is visibleThe text was updated successfully, but these errors were encountered: