Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Navbar Burger missing is-active class #36

Closed
david-nguyen opened this issue Jun 9, 2018 · 7 comments
Closed

Navbar Burger missing is-active class #36

david-nguyen opened this issue Jun 9, 2018 · 7 comments

Comments

@david-nguyen
Copy link

david-nguyen commented Jun 9, 2018

I think it would be an improvement to add the is-active class to the burger button - currently, it only applies the is-active class to the navbar-menu. If you would like I can work on a merge request.

https://bulma.io/documentation/components/navbar/#navbar-burger

@david-nguyen david-nguyen changed the title Navbar Burge missing is-active class Navbar Burger missing is-active class Jun 9, 2018
@VizuaaLOG
Copy link
Owner

Hey David! That's a great idea. If you would like to create a PR that would be appreciated.

@wind930
Copy link

wind930 commented Jul 15, 2018

@VizuaaLOG
Hello, I also encountered the above problems, and later found that the latest source code has been repaired, the version is also updated to 0.6.0, but NPM package still stay in 0.5.0 because there is no 0.6.0 tag's cause, causing NPM not to pull to the latest code, the trouble to update the version of NPM, thank you!

@VizuaaLOG
Copy link
Owner

VizuaaLOG commented Jul 15, 2018

Hey @wind930 0.6.0 is currently still in development and so this change has not yet made it to NPM. I'm currently rewriting the docs for 0.6.0 which is taking longer than expected. If you would like to use the latest navbar change you can pull in the dev branch as everything should be working fine.

@david-nguyen
Copy link
Author

Something seems a bit odd with the script on NPM, it seems to be the older version without applying the css class to the button

@VizuaaLOG
Copy link
Owner

@david-nguyen my reply above explains this. The version with the navbar update has not released yet.

@david-nguyen
Copy link
Author

@VizuaaLOG sorry totally misread your previous comment!

@VizuaaLOG
Copy link
Owner

Hey, @david-nguyen and @wind930 apologies for the delay with this but life took over :(.

I finally had some time to finish the documentation overhaul and have now also pushed 0.6.0 to NPM. The is-active class should now be included within the NPM version.

As always, if you have any more feedback or find a typo within the shiny new docs please open a new issue.

VizuaaLOG pushed a commit that referenced this issue Jun 23, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants