-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Navbar Burger missing is-active class #36
Comments
Hey David! That's a great idea. If you would like to create a PR that would be appreciated. |
@VizuaaLOG |
Hey @wind930 0.6.0 is currently still in development and so this change has not yet made it to NPM. I'm currently rewriting the docs for 0.6.0 which is taking longer than expected. If you would like to use the latest navbar change you can pull in the dev branch as everything should be working fine. |
Something seems a bit odd with the script on NPM, it seems to be the older version without applying the css class to the button |
@david-nguyen my reply above explains this. The version with the navbar update has not released yet. |
@VizuaaLOG sorry totally misread your previous comment! |
Hey, @david-nguyen and @wind930 apologies for the delay with this but life took over :(. I finally had some time to finish the documentation overhaul and have now also pushed 0.6.0 to NPM. The As always, if you have any more feedback or find a typo within the shiny new docs please open a new issue. |
I think it would be an improvement to add the is-active class to the burger button - currently, it only applies the is-active class to the navbar-menu. If you would like I can work on a merge request.
https://bulma.io/documentation/components/navbar/#navbar-burger
The text was updated successfully, but these errors were encountered: