[Modal]: Remove keyup listener on destroy #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this! Good catch! Master is currently going through some major API changes to hopefully simplify the usage. But currently parts are broken and it has no documentation. I'll port your fix back to 0.10 and do a release later today. Thanks again! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #88
Also fixed two minor code style issues currently present in the master.
Note: Unfortunately, I am not sure how to create Modals in the current master with the changed plugin structure. The documented method does not work, an error about "missing root/parent" is thrown by
plugin.js. Otherwise, I would have added unit tests for the issue as well.