[Navbar] Fix navbar hide on scroll behavior, add explicit hide offset #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #90
Basically, I changed the
hideOnScroll
behavior in such a way that the navbar is only hidden if a certain threshold is reached (i.e.scrollY
is farther than the navbar element / sticky offset or configurable parameterhideOffset
), and that the navbar is always reappearing if the scrolling is "at the top" even if the tolerance was not reached (taking same threshold as described above).As a minor thing, I tried to make the options type safer by casting them according to the expected type.
This is a more opinionated change and I am happy to discuss implementation.
(I am using the current version, though, already in an ongoing web project of mine successfully.)
I put this on top of the working 0.10.x branch as otherwise I was not able to properly test it.