Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(NA): Url to state feature. #36

Merged
merged 4 commits into from
Aug 8, 2019
Merged

Conversation

migsar
Copy link

@migsar migsar commented Aug 4, 2019

  1. En el cambio de url se pierden las selecciones previas... tiene sentido en terminos de continuidad, pues podria ser que no esten disponibles los mismos widgets o layers a nivel global. Pero hay otras cosas como basemap o idioma que serian utiles tener como constantes... se puede hacer por otros modos que no sean url.
  2. El poder poner la capa asociada a un widget como activa depende no solo de que la accion de FetchAllLayers ya se haya ejecutado sino de que el layer manager ya haya cargado esa capa... pregunte hoy y existe callback por layers, pero implementar eso no es tan facil, es poner una lista de la layer asociada, crear el callback poner una promesa all que se resuelvan todas y despues ejecutar el toggleActive. Esta delineado pero me parece que no vale la pena por ahora... puse un timeout de 1 segundo y funciona para la mayoria, posiblemente convendria subirlo a 2 cuando haya mas widgets y en la proxima iteracion hacer eso.

@migsar migsar requested a review from davidsingal August 4, 2019 18:44
@davidsingal
Copy link
Contributor

@migh Could you the error Cannot read property 'map' of undefined

It seems to be realted with these file: https://github.com/Vizzuality/mangrove-atlas/pull/36/files#diff-c4fd05998e9de1712eaaff7c29990123

@migsar migsar force-pushed the feature/url-to-state branch from fbd067b to d6f8a34 Compare August 6, 2019 09:45
@migsar migsar requested a review from mluena August 7, 2019 09:34
* develop:
  preselected language styles
  functionality to language selct
  language select component
  language sagas
  transifex WIP
  transifex index + store
  transifex WIP
  language select
@davidsingal davidsingal merged commit 95f17b5 into develop Aug 8, 2019
@davidsingal davidsingal deleted the feature/url-to-state branch August 8, 2019 08:17
lhilarides pushed a commit to lhilarides/mangrove-atlas that referenced this pull request Nov 12, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants