ci: upgrade & improvements (#462)

* Update GitHub Actions versions * Downgrade setup-java * Remove Clean step * Disable nuget package generation on build
Vonage · Jul 24, 2023 · 2b5fad7 · 2b5fad7
1 parent 4e45da2
commit 2b5fad7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 11 deletions.
diff --git a/.github/workflows/multiframework-build.yml b/.github/workflows/multiframework-build.yml
@@ -10,16 +10,16 @@ jobs:
     runs-on: windows-latest
     steps:
       - name: Setup .NET
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
         with:
           dotnet-version: |
             7.0.x
             6.0.x
             3.1.x
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Build
         run: dotnet build --configuration Release
       - name: Test
-        run: dotnet test  --configuration Release --no-build --filter Category!=Integration
+        run: dotnet test  --configuration Release --no-build
         env:
           Vonage.Test.RsaPrivateKey: ${{ secrets.VONAGE_RSA_PRIVATE_KEY }}
diff --git a/.github/workflows/net-build.yml b/.github/workflows/net-build.yml
@@ -15,7 +15,7 @@ jobs:
         with:
           java-version: 1.11
       - name: Setup .NET
-        uses: actions/setup-dotnet@v1
+        uses: actions/setup-dotnet@v3
         with:
           dotnet-version: 7.0.x
       - name: Install SonarScanner
@@ -25,9 +25,7 @@ jobs:
         id: install-coverlet
         run: |
           dotnet tool install --global dotnet-coverage
-      - uses: actions/checkout@v2
-      - name: Clean
-        run: dotnet clean Vonage.sln --configuration Release && dotnet nuget locals all --clear
+      - uses: actions/checkout@v3
       - name: Begin SonarScanner
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

diff --git a/Vonage.Common/Vonage.Common.csproj b/Vonage.Common/Vonage.Common.csproj
@@ -12,7 +12,6 @@
         <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
         <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
         <Version>6.7.0</Version>
-        <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageLicenseExpression />
         <AutoGenerateBindingRedirects>false</AutoGenerateBindingRedirects>
         <LangVersion>latest</LangVersion>

diff --git a/Vonage.Server/Vonage.Server.csproj b/Vonage.Server/Vonage.Server.csproj
@@ -14,8 +14,7 @@
     <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
     <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
     <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
-    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
-      <PackageLicenseExpression />
+    <PackageLicenseExpression/>
     <PackageProjectUrl>https://github.com/Vonage/vonage-dotnet</PackageProjectUrl>
     <PackageReleaseNotes>https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v7.0.4-beta</PackageReleaseNotes>
     <Configurations>Debug;Release;ReleaseSigned</Configurations>

diff --git a/Vonage/Vonage.csproj b/Vonage/Vonage.csproj
@@ -13,7 +13,6 @@
         <GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
         <GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
         <Version>6.7.0</Version>
-        <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <PackageLicenseExpression/>
         <PackageProjectUrl>https://github.com/Vonage/vonage-dotnet</PackageProjectUrl>
         <PackageReleaseNotes>https://github.com/Vonage/vonage-dotnet-sdk/releases/tag/v6.7.0</PackageReleaseNotes>