refactor: use case enhancement (#430)

* Remove unnecessary test over auth * Add tests for Credentials methods
Vonage · Jun 13, 2023 · 851ceac · 851ceac
1 parent 7ba8fd1
commit 851ceac
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 7 deletions.
diff --git a/Vonage.Common.Test/TestHelpers/FakeHttpMessageHandler.cs b/Vonage.Common.Test/TestHelpers/FakeHttpMessageHandler.cs
@@ -39,8 +39,6 @@ private void CompareRequests(ReceivedRequest received, ExpectedRequest expected)
             received.RequestUri.Should()
                 .Be(new Uri(this.baseUri, expected.RequestUri));
             received.Method.Should().Be(expected.Method);
-            received.Headers.Authorization.Scheme.Should().Be("Bearer");
-            received.Headers.Authorization.Parameter.Should().NotBeNullOrWhiteSpace();
             received.Content.Should().Be(expected.Content);
         }
 

diff --git a/Vonage.Common.Test/UseCaseHelper.cs b/Vonage.Common.Test/UseCaseHelper.cs
@@ -219,8 +219,7 @@ public async Task VerifyReturnsUnitGivenApiResponseIsSuccess(ExpectedRequest exp
         public static UseCaseHelper WithSerializer(JsonSerializer serializer) => new(serializer);
 
         private VonageHttpClientConfiguration CreateConfiguration(FakeHttpRequestHandler handler) =>
-            new(handler.ToHttpClient(), new AuthenticationHeaderValue("Bearer", this.Fixture.Create<string>()),
-                this.Fixture.Create<string>());
+            new(handler.ToHttpClient(), new AuthenticationHeaderValue("Anonymous"), this.Fixture.Create<string>());
     }
 
     public struct ExpectedRequest

diff --git a/Vonage.Test.Unit/Request/CredentialsTest.cs b/Vonage.Test.Unit/Request/CredentialsTest.cs
@@ -1,4 +1,7 @@
+using System;
 using System.Collections.Generic;
+using System.Text;
+using FluentAssertions;
 using Vonage.Common.Failures;
 using Vonage.Common.Test.Extensions;
 using Vonage.Request;
@@ -8,6 +11,38 @@ namespace Vonage.Test.Unit.Request
 {
     public class CredentialsTest
     {
+        [Fact]
+        public void GetAuthenticationHeader_ReturnsBasicScheme_GivenContainsApiKeyAndApiSecret() =>
+            BuildBasicCredentials()
+                .GetAuthenticationHeader()
+                .Map(header => header.Scheme)
+                .Should()
+                .BeSuccess("Basic");
+
+        [Fact]
+        public void GetAuthenticationHeader_ReturnsBearerScheme_GivenContainsApplicationIdAndPrivateKey() =>
+            BuildBearerCredentials()
+                .GetAuthenticationHeader()
+                .Map(header => header.Scheme)
+                .Should()
+                .BeSuccess("Bearer");
+
+        [Fact]
+        public void GetAuthenticationHeader_ReturnsEncodedCredentials_GivenContainsApiKeyAndApiSecret() =>
+            BuildBasicCredentials()
+                .GetAuthenticationHeader()
+                .Map(header => header.Parameter)
+                .Should()
+                .BeSuccess(Convert.ToBase64String(Encoding.UTF8.GetBytes("apiKey:apiSecret")));
+
+        [Fact]
+        public void GetAuthenticationHeader_ReturnsToken_GivenContainsApplicationIdAndPrivateKey() =>
+            BuildBearerCredentials()
+                .GetAuthenticationHeader()
+                .Map(header => header.Parameter)
+                .Should()
+                .BeSuccess(success => success.Should().NotBeNullOrWhiteSpace());
+
         public static IEnumerable<object[]> GetInvalidCredentials()
         {
             yield return new object[] {Credentials.FromApiKeyAndSecret("", "apiSecret")};
@@ -26,23 +61,28 @@ public static IEnumerable<object[]> GetInvalidCredentials()
 
         [Fact]
         public void GetPreferredAuthenticationType_ReturnsBasic_GivenContainsApiKeyAndApiSecret() =>
-            Credentials.FromApiKeyAndSecret("apiKey", "apiSecret")
+            BuildBasicCredentials()
                 .GetPreferredAuthenticationType()
                 .Should()
                 .BeSuccess(AuthType.Basic);
 
         [Fact]
         public void GetPreferredAuthenticationType_ReturnsBearer_GivenContainsApplicationIdAndPrivateKey() =>
-            Credentials.FromAppIdAndPrivateKey("appId", "privateKey")
+            BuildBearerCredentials()
                 .GetPreferredAuthenticationType()
                 .Should()
                 .BeSuccess(AuthType.Bearer);
 
         [Theory]
         [MemberData(nameof(GetInvalidCredentials))]
-        public void GetPreferredAuthenticationType_ReturnsNone_GivenInformationIsMissing(Credentials credentials) =>
+        public void GetPreferredAuthenticationType_ReturnsFailure_GivenInformationIsMissing(Credentials credentials) =>
             credentials.GetPreferredAuthenticationType()
                 .Should()
                 .BeFailure(new AuthenticationFailure());
+
+        private static Credentials BuildBasicCredentials() => Credentials.FromApiKeyAndSecret("apiKey", "apiSecret");
+
+        private static Credentials BuildBearerCredentials() => Credentials.FromAppIdAndPrivateKey("appId",
+            Environment.GetEnvironmentVariable("Vonage.Test.RsaPrivateKey"));
     }
 }