refactor: async result extensions (#470)

Vonage · Jul 28, 2023 · edcd78c · edcd78c
1 parent b9e925a
commit edcd78c
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 4 deletions.
diff --git a/Vonage.Common.Test/Extensions/FluentAssertionExtensions.cs b/Vonage.Common.Test/Extensions/FluentAssertionExtensions.cs
@@ -7,5 +7,7 @@ public static class FluentAssertionExtensions
         public static MaybeAssertionExtensions<T> Should<T>(this Maybe<T> instance) => new(instance);
 
         public static ResultAssertionExtensions<T> Should<T>(this Result<T> instance) => new(instance);
+
+        public static ResultAsyncAssertionExtensions<T> Should<T>(this Task<Result<T>> instance) => new(instance);
     }
 }
diff --git a/Vonage.Common.Test/Extensions/ResultAssertionExtensions.cs b/Vonage.Common.Test/Extensions/ResultAssertionExtensions.cs
@@ -116,4 +116,41 @@ private string GetResultFailure() =>
 
         protected override string Identifier => "result";
     }
+
+    public class
+        ResultAsyncAssertionExtensions<T> : ReferenceTypeAssertions<Task<Result<T>>, ResultAsyncAssertionExtensions<T>>
+    {
+        public ResultAsyncAssertionExtensions(Task<Result<T>> subject) : base(subject)
+        {
+        }
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeFailureAsync(Action<IResultFailure> action) =>
+            (await this.InitializeAssertion()).BeFailure(action);
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeFailureAsync() =>
+            (await this.InitializeAssertion()).BeFailure();
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeFailureAsync(IResultFailure expected) =>
+            (await this.InitializeAssertion()).BeFailure(expected);
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeParsingFailureAsync(
+            params string[] failureMessages) =>
+            (await this.InitializeAssertion()).BeParsingFailure(failureMessages);
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeResultFailureAsync(string expectedMessage) =>
+            (await this.InitializeAssertion()).BeResultFailure(expectedMessage);
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeSuccessAsync() =>
+            (await this.InitializeAssertion()).BeSuccess();
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeSuccessAsync(Action<T> action) =>
+            (await this.InitializeAssertion()).BeSuccess(action);
+
+        public async Task<AndConstraint<ResultAssertionExtensions<T>>> BeSuccessAsync(T expected) =>
+            (await this.InitializeAssertion()).BeSuccess(expected);
+
+        private async Task<ResultAssertionExtensions<T>> InitializeAssertion() => new(await this.Subject);
+
+        protected override string Identifier => "resultAsync";
+    }
 }
diff --git a/Vonage.Test.Unit/VerifyV2/Cancel/E2ETest.cs b/Vonage.Test.Unit/VerifyV2/Cancel/E2ETest.cs
@@ -19,10 +19,10 @@ public async Task CancelVerification()
                     .WithHeader("Authorization", "Bearer *")
                     .UsingDelete())
                 .RespondWith(Response.Create().WithStatusCode(HttpStatusCode.OK));
-            var result =
-                await this.Helper.VonageClient.VerifyV2Client.CancelAsync(
-                    CancelRequest.Parse(Guid.Parse("68c2b32e-55ba-4a8e-b3fa-43b3ae6cd1fb")));
-            result.Should().BeSuccess();
+            await this.Helper.VonageClient.VerifyV2Client.CancelAsync(
+                    CancelRequest.Parse(Guid.Parse("68c2b32e-55ba-4a8e-b3fa-43b3ae6cd1fb")))
+                .Should()
+                .BeSuccessAsync();
         }
     }
 }