Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

adding detail to status-webhooks #247

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Conversation

slorello89
Copy link
Contributor

Adding detail field to Status event webhooks

@codecov-io
Copy link

Codecov Report

Merging #247 (a4e3c48) into master (159dcd9) will increase coverage by 0.77%.
The diff coverage is 93.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
+ Coverage   89.10%   89.87%   +0.77%     
==========================================
  Files         385      385              
  Lines       11646    13934    +2288     
  Branches     1113     1548     +435     
==========================================
+ Hits        10377    12523    +2146     
- Misses        991     1035      +44     
- Partials      278      376      +98     
Impacted Files Coverage Δ
Vonage/Redaction/RedactClient.cs 19.23% <0.00%> (-8.55%) ⬇️
Vonage/ShortCodes/ShortCodesClient.cs 8.19% <0.00%> (-2.92%) ⬇️
Vonage/Request/ApiRequest.cs 75.57% <81.04%> (+2.97%) ⬆️
Vonage/Verify/VerifyClient.cs 71.13% <85.29%> (+0.11%) ⬆️
Vonage.Test.Unit/ConversionTest.cs 94.11% <88.23%> (-5.89%) ⬇️
Vonage.Test.Unit/AccountTest.cs 95.37% <90.80%> (-4.63%) ⬇️
Vonage/Voice/VoiceClient.cs 90.87% <93.96%> (+5.24%) ⬆️
Vonage.Test.Unit/VoiceClientTests.cs 97.29% <94.40%> (-2.71%) ⬇️
Vonage.Test.Unit/NumbersTests.cs 96.74% <94.40%> (-2.04%) ⬇️
Vonage.Test.Unit/VerifyTest.cs 97.44% <95.67%> (-1.59%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35ce2a8...a4e3c48. Read the comment docs.

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slorello89 slorello89 merged commit 9266a31 into master Mar 9, 2021
@slorello89 slorello89 deleted the feature/detail-status-webhooks branch March 12, 2021 21:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants