Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add support for proxies in HttpConfig #556

Merged
merged 3 commits into from
Dec 3, 2024
Merged

feat: Add support for proxies in HttpConfig #556

merged 3 commits into from
Dec 3, 2024

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Dec 2, 2024

This PR allows users to set a proxy URL without needing to use the deprecated VonageClient.Builder#httpClient method. This can instead be configured directly in HttpConfig without exposing details of the underlying HTTP client implementation.

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (fe06b81) to head (09447d7).
Report is 72 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #556      +/-   ##
============================================
+ Coverage     95.60%   96.00%   +0.39%     
- Complexity     3427     3754     +327     
============================================
  Files           513      564      +51     
  Lines          8141     8704     +563     
  Branches        451      497      +46     
============================================
+ Hits           7783     8356     +573     
+ Misses          198      175      -23     
- Partials        160      173      +13     
Files with missing lines Coverage Δ
...rc/main/java/com/vonage/client/AbstractMethod.java 100.00% <100.00%> (+22.22%) ⬆️
src/main/java/com/vonage/client/HttpConfig.java 93.93% <100.00%> (+21.59%) ⬆️
src/main/java/com/vonage/client/HttpWrapper.java 100.00% <100.00%> (ø)

... and 32 files with indirect coverage changes

@SMadani SMadani marked this pull request as ready for review December 3, 2024 11:35
@SMadani SMadani merged commit 8a93a6c into main Dec 3, 2024
17 checks passed
@SMadani SMadani deleted the proxy branch December 3, 2024 16:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants