VIDCS-3540: Participant video shows with mobile ratio temporarily #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpettet
changed the title
cpettet
commented
Mar 24, 2025
There was a problem hiding this comment.
Same as VideoLoading component before move, but broke the className out and added the props.
cpettet
changed the title
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Description
The subscriber video would briefly show a non-16:9 ratio black screen/video loading (mobile is much thinner). We wait for the video to start playing and display a loading indicator to ensure a seamless transition. Repurposes our loading indicator for the subscriber video.
GIF (after)
GIF (before)
How should this be manually tested?
Testing the fix
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDCS-3437
Checklist
[✅] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?