Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Made readline only be imported on non-Windows platforms #13

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Made readline only be imported on non-Windows platforms #13

merged 2 commits into from
Jan 25, 2023

Conversation

gingershaped
Copy link
Collaborator

Closes #11.

@gingershaped
Merge pull request #14 from Vyxal/dev
9162eb8 
Didn't do it right the first time
ysthakur
ysthakur approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@ysthakur ysthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I thought Cygwin had readline

@gingershaped
Copy link
Collaborator Author

LGTM, although I thought Cygwin had readline

I'm not sure if it does, the docs page doesn't say. I'm sure it's fine :p

@gingershaped gingershaped merged commit 0a35da7 into dev Jan 25, 2023
@gingershaped gingershaped deleted the fix-windows-readline-error branch January 25, 2023 17:40
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@ysthakur ysthakur ysthakur approved these changes

@lyxal lyxal Awaiting requested review from lyxal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crosshatch crashes on Windows due to missing readline module
2 participants
@gingershaped @ysthakur