Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Add README.md #16

Merged
merged 13 commits into from
Jan 26, 2023
Merged

Add README.md #16

merged 13 commits into from
Jan 26, 2023

Conversation

lyxal
Copy link
Member

@lyxal lyxal commented Jan 26, 2023

Closes #9

Copy link
Collaborator

@gingershaped gingershaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably change the installation section to something like "development installation", because I'm going to package this and put it on PyPI at some point. Also, maybe include some info on multiline code? Otherwise, LGTM. I really like the logo!

@gingershaped
Copy link
Collaborator

Actually, when you removed the background I think you missed a spot in the corner:

image

@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

I'll get on to those a bit later.

@ysthakur
Copy link
Member

Perhaps put development stuff into a CONTRIBUTING.md then?

@gingershaped
Copy link
Collaborator

Perhaps put development stuff into a CONTRIBUTING.md then?

That's not usually what I see projects do, at least for installation instructions.

@gingershaped
Copy link
Collaborator

I'll get on to those a bit later.

Well, I'm gonna go zzz in a few hours, so better make it quick or I'll have to merge it tomorrow morning :p

Copy link
Collaborator

@gingershaped gingershaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the command needs to be poetry run crosshatch with a lowercase c.

@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

Actually, when you removed the background I think you missed a spot in the corner:

image

the AI missed a spot lol

@gingershaped gingershaped added this to the Get the REPL working milestone Jan 26, 2023
@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

Also, the command needs to be poetry run crosshatch with a lowercase c.

works fine with a capital C for me

@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

PS C:...\Documents\Crosshatch> poetry run Crosshatch
Vyxal 2.19.0 using Python 3.10.9 (tags/v3.10.9:1dd9be6, Dec  6 2022, 20:01:21) [MSC v.1934 64 bit (AMD64)] on win32.
Type ##help for more information.
EOF or ##exit to exit.

[0] vyxal>

@gingershaped
Copy link
Collaborator

Huh, weird. I'd still advise changing it, though.

@gingershaped gingershaped added the enhancement New feature or request label Jan 26, 2023
@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

Changes made

@lyxal lyxal requested a review from gingershaped January 26, 2023 02:05
Copy link
Collaborator

@gingershaped gingershaped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once you make the logo change, request a review and I'll merge it.

@lyxal
Copy link
Member Author

lyxal commented Jan 26, 2023

I already changed the logo

@gingershaped
Copy link
Collaborator

Okay, then we're good to merge! Thanks for the help.

@gingershaped gingershaped merged commit 7357514 into dev Jan 26, 2023
@gingershaped gingershaped deleted the add-a-readme branch January 26, 2023 02:09
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write a README
3 participants