-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
F1rst Comm1t!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should probably change the installation section to something like "development installation", because I'm going to package this and put it on PyPI at some point. Also, maybe include some info on multiline code? Otherwise, LGTM. I really like the logo!
I'll get on to those a bit later. |
Perhaps put development stuff into a CONTRIBUTING.md then? |
That's not usually what I see projects do, at least for installation instructions. |
Well, I'm gonna go zzz in a few hours, so better make it quick or I'll have to merge it tomorrow morning :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the command needs to be poetry run crosshatch
with a lowercase c.
works fine with a capital C for me |
|
Huh, weird. I'd still advise changing it, though. |
Changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Once you make the logo change, request a review and I'll merge it.
I already changed the logo |
Okay, then we're good to merge! Thanks for the help. |
Closes #9