Remove aggregatable report limit when trigger context ID is non-null #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
requested review from
csharrison,
vikassahu29,
johnivdel and
akashnadan
vikassahu29
approved these changes
Dec 10, 2024
linnan-github
approved these changes
Dec 11, 2024
|
Please also update the explainer: https://github.com/WICG/attribution-reporting-api/blob/main/AGGREGATE.md#hide-the-true-number-of-attribution-reports |
Done. |
csharrison
approved these changes
Dec 13, 2024
akashnadan
approved these changes
Dec 13, 2024
arpanah
requested changes
Dec 13, 2024
arpanah
approved these changes
Dec 13, 2024
giladbarkan-github
force-pushed
the
trigger_context_id
branch
from
498e518 to
2075829
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jan 21, 2025
WICG/attribution-reporting-api#1475 Bug: 389733591 Change-Id: Ic74cbb00d484112e35edbe40980e6d401f5c6976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6106647 Commit-Queue: Andrew Paseltiner <apaseltiner@chromium.org> Reviewed-by: Nan Lin <linnan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1409200}
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current hard limit on aggregatable reports per source might be too small for
some use-cases. Allowing consumers to manage report counts that already have
privacy constraints applied provides more flexibility. In the case of this
change, when a trigger context ID is supplied, null report rate already manages
the necessary privacy constraints in place of a hard limit on aggregatable
report count.
(See also #1183)
Preview | Diff