Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Logging Format Updates #67

Merged
merged 2 commits into from
Feb 4, 2021
Merged

Logging Format Updates #67

merged 2 commits into from
Feb 4, 2021

Conversation

ric-evans
Copy link
Member

@ric-evans ric-evans commented Feb 4, 2021

Biggest bonus is that coloredlogs includes a timestamp which will make debugging easier

@ric-evans ric-evans requested a review from dsschult February 4, 2021 17:49
@dsschult dsschult requested a review from blinkdog February 4, 2021 17:50
@dsschult
Copy link
Collaborator

dsschult commented Feb 4, 2021

My feelings about colored logs are "meh." (I can change the log formatting to include a timestamp in the python logger too)

But I won't object to it if you want to use colored logs.

@ric-evans
Copy link
Member Author

ric-evans commented Feb 4, 2021

My feelings about colored logs are "meh." (I can change the log formatting to include a timestamp in the python logger too)

But I won't object to it if you want to use colored logs.

k8s logs won't forward the coloring unfortunately (yet?). But, the base formatting is nice, even though that can be done with just logging.basicConfig()

@blinkdog
Copy link
Collaborator

blinkdog commented Feb 4, 2021

Ahhh coloring, takes me back to the days of crafting ANSI escape codes to make output pretty in dial-up modem terminal programs and MS-DOS.

This does make logs harder to use in plain text editors, but there are ways to filter ANSI codes so heck, why not? 😄

@ric-evans ric-evans merged commit 5c11477 into master Feb 4, 2021
@ric-evans ric-evans deleted the logging-format-updates branch February 4, 2021 18:24
@dsschult
Copy link
Collaborator

dsschult commented Feb 4, 2021

note that coloredlogs is aware of the terminal type and won't input ASNI codes into non-interactive terminals (unless you really, really tell it to)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants