Skip to content

refactor(GenerateImageDialogComponent): Convert to standalone #1853

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor(GenerateImageDialogComponent): Convert to standalone #1853

wants to merge 2 commits into from

Conversation

hirokiterashima
Copy link
Member

Changes

  • Convert GenerateImageDialogComponent to standalone component
  • Clean up code

Test

  • Generating image of component and setting it as background (e.g. setting draw as background to graph) work as before

@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Jul 5, 2024
@hirokiterashima hirokiterashima self-assigned this Jul 5, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review July 6, 2024 02:33
geoffreykwan
geoffreykwan approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
No open projects
WISE Development 2023-2024
Status: Todo
Milestone
Tech Debt 16 -> 15
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan