feat(Grade by component): allow teachers to grade by component #2090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent): Convert to standalone (#2018)
…onent structure to use components array instead of node
…average score and completion percentage
…it to work for some components like OR and MC. Had to comment out some component grading modules in ComponentGradingComponent because they cause multiple instances of TeacherDataService to be created
…Component and got the Grading Tool to work without having to instantiate multiple TeacherDataServices
…y first time the NodeGradingComponent was initialized
…WorkgroupItemComponent
…ate component completion.
|
Thanks @Aaron-Detre for the write up. I fixed the issue in this commit 0e21b07 |
|
@breity It looks like mocking (using ng-mocks) components that use FlexLayout (like ComponentClassResponsesComponent and MilestoneReportButtonComponent) in our unit tests is no longer possible in Angular 19. Can you look into removing the FlexLayoutModule dependency from those classes? |
…nts are switched.
Aaron-Detre
requested changes
Mar 6, 2025
|
@Aaron-Detre the UI issue you found looks similar to #2101. I see the problem locally too, but haven't been able to figure it out. @breity can you take a look please? |
Co-authored-by: Jonathan Lim-Breitbart <breity10@gmail.com>
…tedEvent is emitted when button is clicked
Co-authored-by: Jonathan Lim-Breitbart <breity10@gmail.com>
~ Conflicts: ~ src/assets/wise5/directives/summary-display/summary-display.component.ts ~ src/messages.xlf
… component is initialized, and will remain fixed, so we don't need to listen for changes.
…no need to make it more widely available.
…ean up formatting
…changes instead. Remove unused selector. NodeGradingComponent is initialized via the router.
… the first component of the step. In the process, I redid the navigation to rely less on getting the nodeId from dataService and more on getting it from the route and passing it down to child components.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR changes the grade-by-step view to grade-by-component view. This will allow teachers to view one component at a time, and switch between the components using a select drop-down. In the future, we will be adding summary views for more components, like commonly-detected ideas in the DG component.
Test
Choose a step in the Grade-by-step view. It should show the grading view for the first component in the step.
Verify the following:
Closes #2099