Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added an "About" dialog. #477

Closed
wants to merge 14 commits into from
Closed

Added an "About" dialog. #477

wants to merge 14 commits into from

Conversation

AdamuKaapan
Copy link

I decided to go ahead and do a simple about dialog to try and tackle issue #439 (I wanted to try and contribute, and that seemed like an easy place to start that wouldn't mess with too much). Slight disclaimer, I don't know anything about FXML or the conventions/structure of this project: I derived what I can from what I saw (mainly in the settings dialog), but this may be entirely different than what you want/need.

Also, a slight introduction. My name is Adam, I'm a Java programmer with FRC Team 3268, the Valhallabots. I'm beginning to be very interested in vision processing (both in and out of FRC), and I'm hoping to maybe contribute to this project in my spare time, even if it's just small random things like this.

Thanks for making this awesome project, I'm looking forwards to hopefully using it this year!

@codecov-io
Copy link

Current coverage is 49.63%

Merging #477 into master will decrease coverage by -0.71% as of acbec49

@@            master    #477   diff @@
======================================
  Files          130     131     +1
  Stmts         3879    3935    +56
  Branches       426     428     +2
  Methods          0       0       
======================================
  Hit           1953    1953       
  Partial        110     110       
- Missed        1816    1872    +56

Review entire Coverage Diff as of acbec49


Uncovered Suggestions

  1. +0.61% via ...jectAboutDialog.java#55...78
  2. +0.53% via .../ExceptionAlert.java#83...103
  3. +0.48% via ...jectAboutDialog.java#32...50
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@JLLeitschuh
Copy link
Member

New About Dialog

I'd love to see the logo in the about as well.
I think the about should be under another menu separate from "Tools" probably a menu like "Help". @ThomasJClark What do you think?

This is what the "About" screen looks for on Mac and I'd like to see it look more like this.
Mac About Screen

@AdamuKaapan
Copy link
Author

Alright, I'll go ahead and do that. Good idea!

@AdamuKaapan
Copy link
Author

Does that seem better?

@JLLeitschuh
Copy link
Member

Can you upload a screenshot?

@ThomasJClark
Copy link
Contributor

Clicking the hyperlinks just seems to freeze the application up. Can you use hostServices.showDocument()?

@AdamuKaapan
Copy link
Author

Here's a screenshot: https://gyazo.com/ec9100830ae8d9202b3ae08015a4054d

@AdamuKaapan
Copy link
Author

As far as using HostServices, I don't see a way to get the instance of the Application unless you already have one set up? I could probably get one by adding a static variable somewhere or passing it through a few layers of menus? I'm not sure why those links are hanging... I'm on Windows 10 64-bit w/ Java 1.8.0_60 in case that's relevant. Is there anything in the console when you use the link?

@ThomasJClark
Copy link
Contributor

It would probably be a good idea to allow access to the Main instance, since it's a singleton anyways. So, you could do Main.getInstance().getHostServices().showDocument(...).

@AdamuKaapan
Copy link
Author

Should I do that or leave that to you guys?

@AdamuKaapan
Copy link
Author

I'll just push what I did: see if that works.

@AdamuKaapan
Copy link
Author

Any updates on whether this works or not?

@JLLeitschuh
Copy link
Member

@ThomasJClark Says it looks small on Hi-DPI screens. He said he'll include a screenshot later.

@JLLeitschuh
Copy link
Member

Resolved by #588

@JLLeitschuh JLLeitschuh closed this Jun 3, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants