Fix font loading bug #590
Merged
Fix font loading bug #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Current coverage is 64.97%
@@ master #590 diff @@
==========================================
Files 174 174
Lines 5373 5378 +5
Methods 0 0
Messages 0 0
Branches 503 503
==========================================
+ Hits 3493 3494 +1
- Misses 1880 1884 +4
Partials 0 0
|
AustinShalit
force-pushed
the
SpaceInPathToFontBug
branch
from
190bfc7 to
330b69a
Compare
|
ready for review |
|
So what was the problem this was causing? |
AustinShalit
added a commit
to AustinShalit/GRIP
that referenced
this pull request
Jun 1, 2016
JLLeitschuh
pushed a commit
that referenced
this pull request
Jun 3, 2016
* Add About window * Use Application Modal instead of always on top * Add links to Github and ScreenSteps to the about dialog * Apply @JLLeitschuh patch * New button style * Fix open twice bug * Change Cursor to Hand while over links * Use CSS formating instead of Rectangle * Use utility style and autoclose * Fix Windows font bug * Fix tests so a mock network module is now injected * Updated to use Roboto fonts not loaded with CSS (#590) * Remove unused assert
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #589
Solves this using the solution described here.