Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mac keyboard shortcuts now use command #598

Merged

Conversation

AustinShalit
Copy link
Member

Mac keyboard shortcuts used control before. Now they use command. Windows still uses control.

Tested on OS X 10.11.5 and Window 10.

@codecov-io
Copy link

codecov-io commented Jun 2, 2016

Current coverage is 65.25%

Merging #598 into master will increase coverage by <.01%

  1. 2 files (not in diff) in ...va/edu/wpi/grip/core were modified. more
    • Misses -5
    • Hits +5
@@             master       #598   diff @@
==========================================
  Files           174        174          
  Lines          5398       5398          
  Methods           0          0          
  Messages          0          0          
  Branches        517        517          
==========================================
+ Hits           3517       3522     +5   
+ Misses         1881       1876     -5   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by a6d6c07...5aeb89c

@AustinShalit AustinShalit force-pushed the MacKeyboardShortcuts branch from 5aeb89c to 75022c3 Compare June 2, 2016 23:28
@JLLeitschuh
Copy link
Member

Can you explain why this works this way? What up vs down does?

@SamCarlberg
Copy link
Member

Up means that button is up (not pressed). Down means it's pressed

@AustinShalit
Copy link
Member Author

Yup. Just like @SamCarlberg said. Control is the control key but the shortcut modifier is used to represent the modifier key which is used commonly in keyboard shortcuts on the host platform.

@JLLeitschuh JLLeitschuh merged commit fcb4cb9 into WPIRoboticsProjects:master Jun 3, 2016
@AustinShalit AustinShalit deleted the MacKeyboardShortcuts branch June 3, 2016 17:22
@AustinShalit AustinShalit added this to the v2.0.0 milestone Jul 29, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants