Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix massive memory leak in previews (#679) #680

Merged
merged 2 commits into from
Oct 10, 2016

Conversation

SamCarlberg
Copy link
Member

@SamCarlberg SamCarlberg commented Oct 7, 2016

closes #679

Fixes the bug in #679

@SamCarlberg SamCarlberg added this to the v1.5.0 milestone Oct 7, 2016
@codecov-io
Copy link

codecov-io commented Oct 7, 2016

Current coverage is 54.50% (diff: 0.00%)

Merging #680 into master will decrease coverage by 0.09%

@@             master       #680   diff @@
==========================================
  Files           209        209          
  Lines          6700       6706     +6   
  Methods           0          0          
  Messages          0          0          
  Branches        656        656          
==========================================
- Hits           3658       3655     -3   
- Misses         2872       2881     +9   
  Partials        170        170          

Sunburst

Powered by Codecov. Last update f84d379...05c30d3

@AustinShalit AustinShalit changed the title Fix massve memory leak in lines previews (#679) Fix massve memory leak in previews (#679) Oct 7, 2016
@SamCarlberg SamCarlberg mentioned this pull request Oct 10, 2016
4 tasks
@SamCarlberg SamCarlberg changed the title Fix massve memory leak in previews (#679) Fix massive memory leak in previews (#679) Oct 10, 2016
@JLLeitschuh
Copy link
Member

JLLeitschuh commented Oct 10, 2016

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JLLeitschuh JLLeitschuh merged commit 7f1498c into WPIRoboticsProjects:master Oct 10, 2016
@SamCarlberg SamCarlberg deleted the fix/lines-memory branch October 10, 2016 17:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Previewing a lines output makes memory use balloon
3 participants