Improve logging #790
Merged
Improve logging #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gets rid of all the annoying JavaFX and injection crap from the logs
JLLeitschuh
reviewed
Jan 17, 2017
| private static final Logger logger = Logger.getLogger(EventLogger.class.getName()); | ||
|
|
||
| @Subscribe | ||
| public void eventPosted(LoggableEvent event) { |
There was a problem hiding this comment.
Do you want to make it so that this event can be handled by multiple threads simultaneously?
If so you need to add that other annotation (not sure what its called)
There was a problem hiding this comment.
@AllowConcurrentEvents I think
There was a problem hiding this comment.
I'm not going to add the @AllowConcurrentEvents annotation; the event bus is synchronous so only one event will be posted at a time anyway.
Current coverage is 52.51% (diff: 66.66%)@@ master #790 diff @@
==========================================
Files 238 240 +2
Lines 7668 7705 +37
Methods 0 0
Messages 0 0
Branches 739 742 +3
==========================================
+ Hits 3996 4046 +50
+ Misses 3488 3475 -13
Partials 184 184
|
JLLeitschuh
reviewed
Jan 17, 2017
| .toString(); | ||
| } | ||
|
|
||
| private static String simpleString(Socket<?> socket) { |
There was a problem hiding this comment.
Why is this method in the connection class instead of a helper method on the Socket object??
Throw this in a default method on the Socket interface.
JLLeitschuh
requested changes
Jan 17, 2017
SamCarlberg
force-pushed
the
better-logging
branch
from
614f9a7 to
aaafcb5
Compare
JLLeitschuh
approved these changes
Jan 19, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logs are about 1100 lines of debugging stuff from guava and about zero lines of stuff from GRIP. This PR reverses that situation.