Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve UX for saving files #801

Merged
merged 2 commits into from
Jan 27, 2017
Merged

Improve UX for saving files #801

merged 2 commits into from
Jan 27, 2017

Conversation

SamCarlberg
Copy link
Member

  • Changes default save directory from the GRIP location to ~/GRIP/
  • Shows warnings if the project couldn't be saved instead of crashing

Closes #800

AustinShalit
AustinShalit reviewed Jan 26, 2017
View reviewed changes
Copy link
Member

@AustinShalit AustinShalit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably refactor the entire try/catch into a method that takes a file and returns a boolean

@codecov-io
Copy link

codecov-io commented Jan 26, 2017 •
edited
Loading

Current coverage is 52.47% (diff: 0.00%)

Merging #801 into master will decrease coverage by 0.03%

@@             master       #801   diff @@
==========================================
  Files           240        240          
  Lines          7705       7708     +3   
  Methods           0          0          
  Messages          0          0          
  Branches        742        742          
==========================================
- Hits           4046       4045     -1   
- Misses         3475       3479     +4   
  Partials        184        184

Sunburst

Powered by Codecov. Last update 4ce1943...e765ef7

JLLeitschuh
JLLeitschuh approved these changes Jan 27, 2017
View reviewed changes
Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure... This works.

@SamCarlberg SamCarlberg merged commit 6459049 into WPIRoboticsProjects:master Jan 27, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

@AustinShalit AustinShalit AustinShalit approved these changes

Assignees
No one assigned
Labels
location: ui type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamCarlberg @codecov-io @JLLeitschuh @AustinShalit